chore(rust): prune dead scaffolding, dead state and stale allows
The allow audit found thirteen suppressions keeping dead items alive: five placeholder fns (_keep_typed/_unused/_typecheck/_assert_types/_touch), two unused lock helpers, an unused receive-pack wrapper (update_pkts), an unused GraphQL schema wrapper (build_schema_for), two written-never-read fields (RepoSync::cache, EmailQueue::pubsub_url), the generated api_error payload allow (its generated constructors call it) and the pow-solver wasm unused_variables allow (every parameter is used). All removed; imports and the pubsub client helper simplified. The remaining 31 first-party allows (too_many_arguments, module_inception, result_large_err, macro-scoped unreachable_patterns, type_complexity, the reserved Group variant) are load-bearing and stay.
ZhenYi committed
Modified lib/admin/src/services/runners.rs lib/admin/src/services/runners.rs +0 −6 View lib/admin/src/services/runners.rs
@@ -4,7 +4,6 @@
44use models::ci::runner_token;
55use models::ci::workflow_job;
66use models::ci::workflow_run::{self, WorkflowRunState};
7use sea_orm::sea_query::Expr;
87use sea_orm::{
98 ActiveModelTrait, ColumnTrait, EntityTrait, PaginatorTrait, QueryFilter, QueryOrder,
109 QuerySelect, Set,
@@ -416,11 +415,6 @@
416415 .count(self.db().read())
417416 .await? as i64;
418417 Ok((queued, running, failed, succeeded))
419 }
420
421 #[allow(dead_code)]
422 fn _touch(_expr: sea_orm::sea_query::SimpleExpr) {
423 let _ = Expr::value(0);
424418 }
425419}
426420
Modified lib/ci/src/handlers/runner_protocol.rs lib/ci/src/handlers/runner_protocol.rs +2 −9 View lib/ci/src/handlers/runner_protocol.rs
@@ -5,8 +5,8 @@
55
66use ci_protocol::runner::{
77 ArtifactCompleteRequest, ArtifactInitRequest, ArtifactInitResponse, ClaimRequest,
8 ClaimResponse, HeartbeatRequest, HeartbeatResponse, JobFinishRequest, JobFinishState,
9 JobPayload, LogChunksRequest, RegisterRequest, RegisterResponse, StepReport, StepReportState,
8 HeartbeatRequest, HeartbeatResponse, JobFinishRequest, JobPayload, LogChunksRequest,
9 RegisterRequest, RegisterResponse, StepReport,
1010};
1111
1212use crate::errors::ApiError;
@@ -276,11 +276,4 @@
276276 )
277277 .await?;
278278 Ok(AppResponseData::ok(artifact_id))
279}
280
281#[allow(dead_code)]
282fn _assert_types() {
283 let _ = StepReportState::Started;
284 let _ = JobFinishState::Success;
285 let _: Option<ClaimResponse> = None;
286279}
Modified lib/email/src/queue.rs lib/email/src/queue.rs +4 −9 View lib/email/src/queue.rs
@@ -38,8 +38,6 @@
3838 connection: QueueConnection,
3939 config: QueueSettings,
4040 pubsub_client: redis::Client,
41 #[allow(dead_code)]
42 pubsub_url: String,
4341}
4442
4543#[derive(Clone)]
@@ -53,12 +51,11 @@
5351impl EmailQueue {
5452 pub async fn connect(url: &str, config: QueueSettings) -> Result<Self, EmailError> {
5553 let connection = open_connection(url).await?;
56 let (pubsub_client, pubsub_url) = open_pubsub_client(url)?;
54 let pubsub_client = open_pubsub_client(url)?;
5755 Ok(Self {
5856 connection,
5957 config,
6058 pubsub_client,
61 pubsub_url,
6259 })
6360 }
6461
@@ -253,18 +250,16 @@
253250 }
254251}
255252
256fn open_pubsub_client(url: &str) -> Result<(redis::Client, String), EmailError> {
253fn open_pubsub_client(url: &str) -> Result<redis::Client, EmailError> {
257254 if url.split(',').count() > 1 {
258255 let first = url
259256 .split(',')
260257 .map(str::trim)
261258 .find(|s| !s.is_empty())
262259 .ok_or_else(|| EmailError::Config("empty redis url".into()))?;
263 let client = redis::Client::open(first)?;
264 Ok((client, first.to_string()))
260 Ok(redis::Client::open(first)?)
265261 } else {
266 let client = redis::Client::open(url)?;
267 Ok((client, url.to_string()))
262 Ok(redis::Client::open(url)?)
268263 }
269264}
270265
Modified lib/export/src/api_error.rs lib/export/src/api_error.rs +0 −1 View lib/export/src/api_error.rs
@@ -138,7 +138,6 @@
138138 )*
139139 }
140140
141 #[allow(dead_code)]
142141 impl $name {
143142 fn payload(
144143 code: i32,
Modified lib/git/src/handler/graphql.rs lib/git/src/handler/graphql.rs +1 −6 View lib/git/src/handler/graphql.rs
@@ -5,7 +5,7 @@
55use uuid::Uuid;
66
77use crate::errors::ApiError;
8use crate::graphql::{GitSchema, build_schema};
8use crate::graphql::GitSchema;
99use crate::service::GitService;
1010
1111#[utoipa::path(
@@ -45,9 +45,4 @@
4545 let request = async_graphql::Request::new("{ __typename }");
4646 let response = schema.execute(request).await;
4747 Ok(Json(response).into_response())
48}
49
50#[allow(dead_code)]
51pub fn build_schema_for(service: GitService) -> GitSchema {
52 build_schema(service.state)
5348}
Modified lib/git/src/handler/stars.rs lib/git/src/handler/stars.rs +0 −3 View lib/git/src/handler/stars.rs
@@ -116,6 +116,3 @@
116116 .map_err(GitApiError::from)?;
117117 Ok(AppResponseData::ok(out))
118118}
119
120#[allow(dead_code)]
121fn _typecheck(_: AppResponseData<RepoStarResp>) {}
Modified lib/git/src/smart/dispatch.rs lib/git/src/smart/dispatch.rs +0 −5 View lib/git/src/smart/dispatch.rs
@@ -1,4 +1,3 @@
1use std::path::PathBuf;
21use std::sync::Arc;
32
43use axum::body::Body;
@@ -10,7 +9,6 @@
109use std::io::Read;
1110use uuid::Uuid;
1211
13use crate::context::facade::GitContext;
1412use crate::share::access::{BasicAuth, allow_repo_read, require_writer};
1513use crate::smart::error::{SmartError, SmartResult};
1614use crate::smart::info_refs as info_refs_module;
@@ -264,6 +262,3 @@
264262 Ok(bytes)
265263 }
266264}
267
268#[allow(dead_code)]
269fn _unused(_ctx: &GitContext, _p: &PathBuf) {}
Modified lib/git/src/smart/pre_receive.rs lib/git/src/smart/pre_receive.rs +0 −6 View lib/git/src/smart/pre_receive.rs
@@ -1,4 +1,3 @@
1use bytes::Bytes;
21use globset::{Glob, GlobMatcher};
32use sea_orm::{ColumnTrait, EntityTrait, QueryFilter};
43use uuid::Uuid;
@@ -309,9 +308,4 @@
309308 });
310309 }
311310 Ok(out)
312}
313
314#[allow(dead_code)]
315pub fn update_pkts(input: &Bytes) -> SmartResult<Vec<RefUpdate>> {
316 parse_receive_pack_refs(input)
317311}
Modified lib/git/src/ssh/handler/command.rs lib/git/src/ssh/handler/command.rs +0 −3 View lib/git/src/ssh/handler/command.rs
@@ -291,6 +291,3 @@
291291 }
292292 Ok(out)
293293}
294
295#[allow(dead_code)]
296fn _keep_typed(_: GitError) {}
Modified lib/git/src/sync/lock.rs lib/git/src/sync/lock.rs +0 −11 View lib/git/src/sync/lock.rs
@@ -1,5 +1,4 @@
11use std::process;
2use std::sync::Arc;
32
43use export::{AppRedis, RedisConnection};
54use uuid::Uuid;
@@ -107,14 +106,4 @@
107106 key,
108107 value,
109108 }))
110}
111
112#[allow(dead_code)]
113pub(crate) fn lock_handle(redis: AppRedis, key: String, value: String) -> SyncLock {
114 SyncLock { redis, key, value }
115}
116
117#[allow(dead_code)]
118pub(crate) fn lock_key_for(repo_id: Uuid) -> Arc<str> {
119 Arc::from(lock_key(repo_id))
120109}
Modified lib/git/src/sync/sync.rs lib/git/src/sync/sync.rs +0 −3 View lib/git/src/sync/sync.rs
@@ -39,8 +39,6 @@
3939 repo: repos::Model,
4040 baby: GitBaby,
4141 redis: export::AppRedis,
42 #[allow(dead_code)]
43 cache: Arc<CacheClient>,
4442 repo_root: PathBuf,
4543 settings: SyncSettings,
4644}
@@ -66,7 +64,6 @@
6664 repo,
6765 baby: GitBaby::new(Arc::new(ctx)),
6866 redis,
69 cache,
7067 repo_root,
7168 settings,
7269 }
Modified lib/pow-solver/src/wasm.rs lib/pow-solver/src/wasm.rs +0 −2 View lib/pow-solver/src/wasm.rs
@@ -1,5 +1,3 @@
1#![allow(unused_variables)]
2
31use wasm_bindgen::prelude::*;
42
53use crate::challenge::{check as check_native, solve as solve_native};